Reduce gc alloc #23
Merged
Reduce gc alloc #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fair point, I wasn't aware that getting the vertex list had this overhead. |
|
Thanks merge! I didn't know this either until I discovered this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice to meet you.
I am an engineer who has recently been looking into ways to improve the load times on Koikatsu.
There was a bit of heavy code in SexFace. This is a PR that fixes that.
Please merge if you don't mind.
Thanks for the nice plugin.
The internal alloc of mesh.vertices in the following code from AddLopsided was slowing things down.
One call to mesh.vertices is not a significant load, but the number of calls seems to have been too many.
I added the following logs before and after the series of processes and measured the time. it took 0.5 to 0.7 seconds per character.
I think the GCBytes is negative because the garbage collector was activated.
I was able to get around this by first getting mesh.vertices and then using it around.
This modification reduces the loading time for a scene with about 20 characters in place from 50 to 45 seconds.